Re: [PATCH 3/3] selftests: vDSO: chacha: Provide default definition of HWCAP_S390_VXRS

[Heiko Carstens]

On Mon, Mar 24, 2025 at 03:03:17PM +0100, Thomas Weißschuh wrote:
> s390 does not provide a hwcap.h UAPI header.
> 
> Add an inline definition for the constant HWCAP_S390_VXRS until a proper
> UAPI header is introduced.
> 
> Fixes: 210860e7f733 ("selftests: vDSO: check cpu caps before running chacha test")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> ---
>  tools/testing/selftests/vDSO/vdso_test_chacha.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_chacha.c b/tools/testing/selftests/vDSO/vdso_test_chacha.c
> index fd5c5108b42f04ec459d39b74f33edc2ceafbba1..0ce5189718ce35b0a4d69b71559db8379b598b93 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_chacha.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_chacha.c
> @@ -19,6 +19,9 @@ static bool cpu_has_capabilities(void)
>  	return getauxval(AT_HWCAP) & HWCAP_ASIMD;
>  }
>  #elif defined(__s390x__)
> +#ifndef HWCAP_S390_VXRS
> +#define HWCAP_S390_VXRS	(1 << 11)
> +#endif
>  static bool cpu_has_capabilities(void)
>  {
>  	return getauxval(AT_HWCAP) & HWCAP_S390_VXRS;

How did this cause a problem?

Did you use something different than glibc(-devel) on your test
system? Just wondering since glibc-devel provides the define since
ages and is also required for getauxval().