Re: [PATCH v1 2/4] dt-bindings: mfd: Document Infineon/Cypress CG7153AM MCU

[Rob Herring]

On Sun, Mar 23, 2025 at 09:14:22AM +0200, Svyatoslav Ryhel wrote:
> Add binding for Cypress CG7153AM embedded controller. Pegatron implemented
> a custom configuration of this MCU in their Chagall tablets, utilizing it
> for battery monitoring.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> ---
>  .../bindings/mfd/cypress,cg7153am.yaml        | 55 +++++++++++++++++++
>  1 file changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/cypress,cg7153am.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/cypress,cg7153am.yaml b/Documentation/devicetree/bindings/mfd/cypress,cg7153am.yaml
> new file mode 100644
> index 000000000000..f8469b5e3816
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/cypress,cg7153am.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/cypress,cg7153am.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon/Cypress Semicon CG7153AM Microcontroller
> +
> +maintainers:
> +  - Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> +
> +description:
> +  The CG7153AM, an 8-bit programmable microcontroller from Infineon/Cypress
> +  Semiconductor, communicates over I2C and is implemented in devices like the
> +  Pegatron Chagall tablet for fuel gauge and battery control functions.
> +
> +$ref: /schemas/power/supply/power-supply.yaml
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - pegatron,chagall-ec # Pegatron Chagall tablet device
> +          - const: cypress,cg7153am
> +      - items:
> +          const: cypress,cg7153am

Is this just some general purpose uC which could be used for anything 
and the interface exposed is Pegatron's invention. If so, then I'd drop 
the cypress,cg7153am compatible. What use would it be to software?

> +
> +  reg:
> +    maxItems: 1
> +
> +  monitored-battery: true
> +  power-supplies: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        embedded-controller@10 {
> +            compatible = "pegatron,chagall-ec", "cypress,cg7153am";
> +            reg = <0x10>;
> +
> +            monitored-battery = <&battery>;
> +            power-supplies = <&mains>;
> +        };
> +    };
> +...
> -- 
> 2.43.0
>