RE: [EXT] Re: [PATCH v4 2/2] wifi: mwifiex: Fix RF calibration data download from file

[Jeff Chen]

> -----Original Message-----
> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Sent: Monday, March 24, 2025 3:02 PM
> To: Jeff Chen <jeff.chen_1@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> briannorris@xxxxxxxxxxxx; johannes@xxxxxxxxxxxxxxxx; francesco@xxxxxxxxxx;
> Pete Hsieh <tsung-hsien.hsieh@xxxxxxx>
> Subject: [EXT] Re: [PATCH v4 2/2] wifi: mwifiex: Fix RF calibration data
> download from file
> 
> > @@ -454,6 +454,11 @@ enum mwifiex_channel_flags {
> >  #define HostCmd_RET_BIT                       0x8000
> >  #define HostCmd_ACT_GEN_GET                   0x0000
> >  #define HostCmd_ACT_GEN_SET                   0x0001
> > +#define HOST_CMD_ACT_GEN_SET                  0x0001
> > +/* Add this non-CamelCase-style macro to comply with checkpatch
> requirements.
> > + *  This macro will eventually replace all existing CamelCase-style
> > +macros in
> > + *  the future for consistency.
> > + */
> 
> Just ignore this checkpatch warning. We don't want to have duplicated defines
> just for silencing checkpatch. If anything we could change all the CamelCase
> defines throughout the driver in one go.
> 
> Sascha
> 

Hello Sascha,  

I'll proceed with reverting the duplicated defines and ignoring the checkpatch warning
for now.  

Thank you for pointing this out.  

Best regards,  
Jeff