Re: [PATCH 1/1] media: dt-bindings: Add OmniVision OV02C10
From: Rob Herring
Date: Mon Mar 24 2025 - 13:15:16 EST
On Mon, Mar 24, 2025 at 12:09:12AM +0000, Bryan O'Donoghue wrote:
> Add bindings for OVO2C10 a two megapixel 1080p RGB sensor.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
> .../bindings/media/i2c/ovti,ov02c10.yaml | 117 ++++++++++++++++++
> 1 file changed, 117 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02c10.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02c10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02c10.yaml
> new file mode 100644
> index 000000000000..6380a17fe65f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02c10.yaml
> @@ -0,0 +1,117 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) 2025 Linaro Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov02c10.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Omnivision OV02C10 CMOS Sensor
> +
> +maintainers:
> + - Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> +
> +description: |
> + The Omnivision OV02C10 is a 2 megapixel, CMOS image sensor which supports:
> + - Automatic black level calibration (ABLC)
> + - Programmable controls for frame rate, mirror and flip, binning, cropping
> + and windowing
> + - Output formats 10-bit 4C RGB RAW, 10-bit Bayer RAW
> + - 2-lane MIPI D-PHY TX @ 800 Mbps per lane
> + - 1-lane MIPI D-PHY TX @ 1.5 Gbps per lane
> + - Dynamic defect pixel cancellation
> + - Standard SCCB command interface
> +
> +allOf:
> + - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> + compatible:
> + const: ovti,ov02c10
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + avdd-supply:
> + description: Analogue circuit voltage supply.
> +
> + dovdd-supply:
> + description: I/O circuit voltage supply.
> +
> + dvdd-supply:
> + description: Digital circuit voltage supply.
> +
> + reset-gpios:
> + description: Active low GPIO connected to XSHUTDOWN pad of the sensor.
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + additionalProperties: false
> +
> + properties:
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - items:
> + - const: 1
> + - const: 2
minItems: 1
And drop the first oneOf entry (and oneOf).
> + link-frequencies: true
> + remote-endpoint: true
> +
> + required:
> + - data-lanes
> + - link-frequencies
> + - remote-endpoint
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ov02c10: camera@36 {
> + compatible = "ovti,ov02c10";
> + reg = <0x36>;
> +
> + reset-gpios = <&tlmm 237 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&cam_rgb_defaultt>;
> +
> + clocks = <&ov02c10_clk>;
> +
> + assigned-clocks = <&ov02c10_clk>;
> + assigned-clock-parents = <&ov02c10_clk_parent>;
> + assigned-clock-rates = <19200000>;
> +
> + avdd-supply = <&vreg_l7b_2p8>;
> + dvdd-supply = <&vreg_l7b_1p8>;
> + dovdd-supply = <&vreg_l3m_1p8>;
> +
> + port {
> + ov02c10_ep: endpoint {
> + remote-endpoint = <&csiphy4_ep>;
> + data-lanes = <1 2>;
> + link-frequencies = /bits/ 64 <400000000>;
> + };
> + };
> + };
> + };
> +...
> --
> 2.49.0
>