Re: [PATCH RFC net-next v1] page_pool: import Jesper's page_pool benchmark

[Mina Almasry]

On Mon, Mar 24, 2025 at 6:56 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Sun,  9 Mar 2025 08:41:18 +0000 Mina Almasry wrote:
> >  lib/Kconfig                        |   2 +
> >  lib/Makefile                       |   2 +
> >  lib/bench/Kconfig                  |   4 +
> >  lib/bench/Makefile                 |   3 +
> >  lib/bench/bench_page_pool_simple.c | 328 ++++++++++++++++++++++
> >  lib/bench/time_bench.c             | 426 +++++++++++++++++++++++++++++
> >  lib/bench/time_bench.h             | 259 ++++++++++++++++++
>
> Why not in tools/testing? I thought selftest infra supported modules.

You must be referring to TEST_GEN_MODS_DIR? Yes, that seems better. We
don't use it in tools/testing/selftests/net but it is used in
tool/testing/selftests/mm and page_frag_test.ko is a very similar
example. I can put it in tools/testing/selftests/net/page_pool_bench
or something like that.

Also I guess you're alluding that this benchmark should be a selftest
as well, right? I can make it a selftest but probably for starters the
test will run and output the perf data but will exit code 4 to skip,
right? I'm not sure it is consistent enough to get pass/fail data from
it. When I run it in my env it's mostly consistent but i'm not sure
across evironments.

-- 
Thanks,
Mina