Re: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI

[Wolfram Sang]

> > > +config SERIAL_RZ_SCI
> > 
> > I think this name is too generic. Most RZ-variants so far do not have this
> > SoC. Would 'RZT2H' work or is it too narrow then?
> 
> This is too narrow, because for instance the RZ/N2H , which is very similar, has the same SCI

You know the differences better, what could be a suitable name?

> > >  #define PORT_GENERIC	(-1)
> > 
> > Does userspace need to know this port? Can't we use PORT_GENERIC?
> 
> Userspace unlikely needs it. But unfortunately, the port type needs to
> be checked at a number (5) of places in the driver, so the definition
> is needed.

Yes, true. You just keep consistent with the driver. OK.

Attachment: signature.asc
Description: PGP signature