Re: [PATCH v4 2/2] platform/x86: asus-wmi: Refactor Ally suspend/resume

From: Luke D. Jones
Date: Mon Mar 24 2025 - 18:39:36 EST


On 25/03/25 01:10, Ilpo Järvinen wrote:
On Sun, 23 Mar 2025, Luke Jones wrote:

From: "Luke D. Jones" <luke@xxxxxxxxxx>

Adjust how the CSEE direct call hack is used.

The results of months of testing combined with help from ASUS to
determine the actual cause of suspend issues has resulted in this
refactoring which immensely improves the reliability for devices which
do not have the following minimum MCU FW version:
- ROG Ally X: 313
- ROG Ally 1: 319

For MCU FW versions that match the minimum or above the CSEE hack is
disabled and mcu_powersave set to on by default as there are no
negatives beyond a slightly slower device reinitialization due to the
MCU being powered off.

As this is set only at module load time, it is still possible for
mcu_powersave sysfs attributes to change it at runtime if so desired.

Signed-off-by: Luke D. Jones <luke@xxxxxxxxxx>

This series update lost Mario's rev-bys (given in replies to v3). Was that
intentional??

No it wasn't. I must have messed up with git.

@ Mario would you mind adding again? There are very few changes.