[PATCH 0/2] x86 unwind fixes (1 unwinder fix, 1 missing entry ORC annotation)
From: Jann Horn
Date: Mon Mar 24 2025 - 22:01:47 EST
While doing some kernel development, I managed to cause a recursive #PF
ending in a #DF, as one does... Thanks Andy for adding guard stacks and
such nice error handling for them years ago.
Unfortunately, instead of a nice stack trace, I just got a pile of guess
unwind lines, caused by two bugs.
Here are fixes I came up with for these issues. The issues were
introduced in 2018 and 2023 - if nobody else noticed them since then,
I guess the fixes aren't particularly urgent.
To: Andy Lutomirski <luto@xxxxxxxxxx>
Cc: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
To: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
Cc: Vernon Lovejoy <vlovejoy@xxxxxxxxxx>
Signed-off-by: Jann Horn <jannh@xxxxxxxxxx>
---
Jann Horn (2):
x86/entry: Fix ORC for PUSH_REGS with save_ret=1
x86/dumpstack: Fix broken unwinding from exception stacks
arch/x86/entry/calling.h | 2 ++
arch/x86/kernel/dumpstack.c | 5 ++---
2 files changed, 4 insertions(+), 3 deletions(-)
---
base-commit: bcb044256d3f5d9f5bb61d1eac6492f77883bd60
change-id: 20250325-2025-03-unwind-fixes-a367c54be822
--
Jann Horn <jannh@xxxxxxxxxx>