Re: [PATCH] ARM: davinci: always enable CONFIG_ARCH_DAVINCI_DA850

[Bartosz Golaszewski]

On Mon, Mar 24, 2025 at 10:33 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> A change to the clk driver broke configurations that enable DA830
> but not DA850:
>
> arm-linux-gnueabi-ld: drivers/clk/davinci/pll.o: in function `__da850_pll0_of_clk_init_declare':
> pll.c:(.init.text+0x30): undefined reference to `of_da850_pll0_init'
> arm-linux-gnueabi-ld: drivers/clk/davinci/pll.o:(.rodata.davinci_pll_id_table+0x14): undefined reference to `da850_pll0_init'
> arm-linux-gnueabi-ld: drivers/clk/davinci/pll.o:(.rodata.davinci_pll_id_table+0x2c): undefined reference to `da850_pll1_init'
> arm-linux-gnueabi-ld: drivers/clk/davinci/pll.o:(.rodata.davinci_pll_of_match+0xc0): undefined reference to `of_da850_pll1_init'
> arm-linux-gnueabi-ld: drivers/clk/davinci/psc.o:(.rodata.davinci_psc_id_table+0x14): undefined reference to `da850_psc0_init_data'
> arm-linux-gnueabi-ld: drivers/clk/davinci/psc.o:(.rodata.davinci_psc_id_table+0x2c): undefined reference to `da850_psc1_init_data'
>
> Select ARCH_DAVINCI_DA850 unconditionally to ensure the driver can still
> build.
>
> Fixes: a31b4dcf188c ("clk: davinci: remove support for da830")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  arch/arm/mach-davinci/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index 3fa15f342240..8f66de0405d9 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -4,6 +4,7 @@ menuconfig ARCH_DAVINCI
>         bool "TI DaVinci"
>         depends on ARCH_MULTI_V5
>         depends on CPU_LITTLE_ENDIAN
> +       select ARCH_DAVINCI_DA850
>         select CPU_ARM926T
>         select DAVINCI_TIMER
>         select ZONE_DMA
> --
> 2.39.5
>

Thanks and sorry for the trouble. FYI I want to remove all traces of
da830 during this cycle leaving da850 as the only platform upstream.

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>