Re: [PATCH v6 0/6] Enable IPQ5018 PCI support

[George Moussalem]

On 3/24/25 11:47, Krzysztof Kozlowski wrote:
> On Fri, Mar 21, 2025 at 04:14:38PM +0400, George Moussalem wrote:
> > This patch series adds the relevant phy and controller
> > DT configurations for enabling PCI gen2 support
> > on IPQ5018. IPQ5018 has two phys and two controllers,
> > one dual-lane and one single-lane.
> >
> > Last patch series (v3) submitted dates back to August 30, 2024.
> > As I've worked to add IPQ5018 platform support in OpenWrt, I'm
> > continuing the efforts to add Linux kernel support.
> >
> > Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
> > ---
> > Changes in v6:
> > - Fixed issues reported by 'make dt_bindings_check' as per Rob's bot
> > - Removed Krzysztof's Ack-tag on
>
> Why?

In v5, I modified dt bindings (patch 1) to add descriptions and separate 
conditions for ipq5018 and ipq5332 as they have different nr of clocks 
and resets but left your tag in there. I removed it in v6 to run the 
changes past you again.

I intend to send the next version with comments addressed in patch 5 (to 
add a comment above the max-link-speed property). Anything else you 
would like to see addressed?

> Again, I cannot compare this serie:
>
>    b4 diff '20250321-ipq5018-pcie-v6-0-b7d659a76205@xxxxxxxxxxx'
>    Grabbing thread from lore.kernel.org/all/20250321-ipq5018-pcie-v6-0-b7d659a76205@xxxxxxxxxxx/t.mbox.gz
>    Checking for older revisions
>    Grabbing search results from lore.kernel.org
>    Nothing matching that query.
>    ---
>    Analyzing 12 messages in the thread
>    Could not find lower series to compare against.

I tried 'b4 prep -n <topical branch> -F <message-ID>' to try and preseve 
the history but that didn't work, unfortunately. Instead I used -f and 
forked it off the master branch of linux-next.

>

Best regards,
George