Re: [PATCH v3 01/20] tools/x86/kcpuid: Fix error handling

From: Ingo Molnar
Date: Tue Mar 25 2025 - 04:55:43 EST



* Ahmed S. Darwish <darwi@xxxxxxxxxxxxx> wrote:

> static void usage(void)
> {
> - printf("kcpuid [-abdfhr] [-l leaf] [-s subleaf]\n"
> - "\t-a|--all Show both bit flags and complex bit fields info\n"
> - "\t-b|--bitflags Show boolean flags only\n"
> - "\t-d|--detail Show details of the flag/fields (default)\n"
> - "\t-f|--flags Specify the cpuid csv file\n"
> - "\t-h|--help Show usage info\n"
> - "\t-l|--leaf=index Specify the leaf you want to check\n"
> - "\t-r|--raw Show raw cpuid data\n"
> - "\t-s|--subleaf=sub Specify the subleaf you want to check\n"
> + warnx("kcpuid [-abdfhr] [-l leaf] [-s subleaf]\n"
> + "\t-a|--all Show both bit flags and complex bit fields info\n"
> + "\t-b|--bitflags Show boolean flags only\n"
> + "\t-d|--detail Show details of the flag/fields (default)\n"
> + "\t-f|--flags Specify the cpuid csv file\n"
> + "\t-h|--help Show usage info\n"
> + "\t-l|--leaf=index Specify the leaf you want to check\n"
> + "\t-r|--raw Show raw cpuid data\n"
> + "\t-s|--subleaf=sub Specify the subleaf you want to check"

Here you missed a few cases of:

s/csv/CSV
s/cpuid/CPUID

I fixed this all up in the patches & commits, no need to resend.

Thanks,

Ingo