Re: [PATCH] soc: qcom: pmic_glink_altmode: fix spurious DP hotplug events
From: Konrad Dybcio
Date: Tue Mar 25 2025 - 07:29:50 EST
On 3/25/25 9:40 AM, Johan Hovold wrote:
> On Mon, Mar 24, 2025 at 08:21:10PM +0100, Konrad Dybcio wrote:
>> On 3/24/25 2:24 PM, Johan Hovold wrote:
>>> The PMIC GLINK driver is currently generating DisplayPort hotplug
>>> notifications whenever something is connected to (or disconnected from)
>>> a port regardless of the type of notification sent by the firmware.
>>
>> Yikes!
>>
>> Acked-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>>
>> That said, I'm hoping there isn't any sort of "port is full of water,
>> emergency" messages that we should treat as "unplug" though..
>
> Seems a bit far fetched, but I guess only you guys inside Qualcomm can
> try to figure that out.
I tried looking around, but couldn't find anything like that
> An alternative could be to cache the hpd_state regardless of the svid
> and only forward changes. But perhaps the hpd_state bit is only valid
> for DP notifications.
The current state of your patch seems to be a good approach, I think.
Konrad