Re: [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description (fec,mtip-switch.yaml)

[Krzysztof Kozlowski]

On 25/03/2025 12:57, Lukasz Majewski wrote:
> This patch provides description of the MTIP L2 switch available in some
> NXP's SOCs - imx287, vf610.
> 
> Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
> ---
>  .../bindings/net/fec,mtip-switch.yaml         | 160 ++++++++++++++++++

Use compatible as filename.

>  1 file changed, 160 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/fec,mtip-switch.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/fec,mtip-switch.yaml b/Documentation/devicetree/bindings/net/fec,mtip-switch.yaml
> new file mode 100644
> index 000000000000..cd85385e0f79
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/fec,mtip-switch.yaml
> @@ -0,0 +1,160 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/fsl,mtip-switch.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale MTIP Level 2 (L2) switch
> +
> +maintainers:
> +  - Lukasz Majewski <lukma@xxxxxxx>
> +

description?

> +allOf:
> +  - $ref: ethernet-controller.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:

Drop, you have only one variant.

> +      - enum:
> +	  - imx287-mtip-switch

This wasn't tested. Except whitespace errors, above compatible does not
have format of compatible. Please look at other NXP bindings.

Missing blank line.

> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 3

Need to list items instead.

> +
> +  clocks:
> +    maxItems: 4
> +    description:
> +      The "ipg", for MAC ipg_clk_s, ipg_clk_mac_s that are for register accessing.
> +      The "ahb", for MAC ipg_clk, ipg_clk_mac that are bus clock.
> +      The "ptp"(option), for IEEE1588 timer clock that requires the clock.
> +      The "enet_out"(option), output clock for external device, like supply clock
> +      for PHY. The clock is required if PHY clock source from SOC.

Same problems. This binding does not look at all as any other binding. I
finish review here, but the code has similar trivial issues all the way,
including incorrect indentation. Start from well reviewed existing
binding or example-schema.

Best regards,
Krzysztof