Re: [PATCH v6 07/11] misc: amd-sbi: Add support for mailbox error codes

[Gupta, Akshay]

On 3/24/2025 8:56 PM, Arnd Bergmann wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Mon, Mar 24, 2025, at 15:58, Akshay Gupta wrote:
> > APML mailbox protocol returns additional error codes written by
> > SMU firmware in the out-bound register 0x37. These errors include,
> > invalid core, message not supported over platform and
> > others. This additional error codes can be used to provide more
> > details to user space.
> >
> > Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@xxxxxxx>
> > Signed-off-by: Akshay Gupta <akshay.gupta@xxxxxxx>
> This is an incompatible change to the uapi definition, which you
> should never do. Just merge it into the previous patch that
> adds the api in the first place.
>
>        Arnd
Thank you, will squash in previous patch.