Re: [PATCH v4 03/11] scripts: generate_rust_analyzer.py: add trailing comma
From: Daniel Almeida
Date: Tue Mar 25 2025 - 09:30:45 EST
> On 22 Mar 2025, at 10:23, Tamir Duberstein <tamird@xxxxxxxxx> wrote:
>
> Add missing trailing comma on multi-line function call as suggested by
> PEP-8:
>
>> The pattern is to put each value (etc.) on a line by itself, always
>> adding a trailing comma, and add the close parenthesis/bracket/brace
>> on the next line.
>
> This change was made by a code formatting tool.
>
> Reviewed-by: Fiona Behrens <me@xxxxxxxxxx>
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
> ---
> scripts/generate_rust_analyzer.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index e2bc4a717f87..e997d923268d 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -180,7 +180,7 @@ def main():
>
> logging.basicConfig(
> format="[%(asctime)s] [%(levelname)s] %(message)s",
> - level=logging.INFO if args.verbose else logging.WARNING
> + level=logging.INFO if args.verbose else logging.WARNING,
> )
>
> # Making sure that the `sysroot` and `sysroot_src` belong to the same toolchain.
>
> --
> 2.48.1
>
>
Reviewed-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>