Re: [PATCH 2/2] x86/dumpstack: Fix broken unwinding from exception stacks
From: Oleg Nesterov
Date: Tue Mar 25 2025 - 09:38:58 EST
On 03/25, Jann Horn wrote:
>
> Commit 2e4be0d011f2 ("x86/show_trace_log_lvl: Ensure stack pointer is
> aligned, again") was intended to ensure alignment of the stack pointer; but
> it also moved the initialization of the "stack" variable down into the loop
> header. This was likely intended as a no-op cleanup, since the commit
> message does not mention it;
Yes... initial version didn't do this, this was requested during review
and I didn't realize this adds another problem.
Thanks Jann!
Oleg.