Re: [PATCH v3 0/2] selftests: livepatch: test if ftrace can trace a livepatched function

From: Joe Lawrence
Date: Tue Mar 25 2025 - 09:40:17 EST


On Mon, Mar 24, 2025 at 07:50:17PM -0300, Filipe Xavier wrote:
> This patchset add ftrace helpers functions and
> add a new test makes sure that ftrace can trace
> a function that was introduced by a livepatch.
>
> Signed-off-by: Filipe Xavier <felipeaggger@xxxxxxxxx>
> Suggested-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>
> Reviewed-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>
> Acked-by: Miroslav Benes <mbenes@xxxxxxx>
> ---
> Changes in v3:
> - functions.sh: fixed sed to remove warning from shellcheck and add grep -Fw params.

Oh, now I see what shellcheck was complaining about. I missed that
there was no '\' line continuation char at the end of the sed line. I
thought it was complaining about starting the subsequent lines with the
'|' and '>' redirection chars. Good eye on catching that :)

> - test-ftrace.sh: change constant to use common SYSFS_KLP_DIR.
> - Link to v2: https://lore.kernel.org/r/20250318-ftrace-sftest-livepatch-v2-0-60cb0aa95cca@xxxxxxxxx
>

For both patches:
Acked-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>

Thanks,
-- Joe