Re: [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description (fec,mtip-switch.yaml)

[Lukasz Majewski]

Hi Krzysztof,

> On 25/03/2025 13:39, Lukasz Majewski wrote:
> > Hi Krzysztof,
> >   
> >> On 25/03/2025 13:15, Lukasz Majewski wrote:  
> >>> Hi Krzysztof,
> >>>     
> >>>> On 25/03/2025 12:57, Lukasz Majewski wrote:    
> >>>>> This patch provides description of the MTIP L2 switch available
> >>>>> in some NXP's SOCs - imx287, vf610.
> >>>>>
> >>>>> Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
> >>>>> ---
> >>>>>  .../bindings/net/fec,mtip-switch.yaml         | 160
> >>>>> ++++++++++++++++++      
> >>>>
> >>>> Use compatible as filename.    
> >>>
> >>> I've followed the fsl,fec.yaml as an example. This file has
> >>> description for all the device tree sources from fec_main.c    
> >>
> >>
> >> That's a 14 year old binding, so clear antipattern.  
> > 
> > For some reason it is still there...  
> 
> And it will be there for very long time. Bindings are not removed just
> because they are old, because they are an ABI. That's still not a
> reason to use something old as starting point.

It was unintentional - if I would know that fsl,fec.yaml is so old, I
would use another one as a starting point.

I will use more recent one to provide proper bindings for this driver.

> 
> It's the same with drivers, although driver can be easier changed and
> old pattern can be dropped. You cannot easily drop old, anti-patterns
> from the binding.

Yes, I'm fully aware of the problem.

> 
> Best regards,
> Krzysztof




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@xxxxxxx

Attachment: pgpCsBxLq6MEH.pgp
Description: OpenPGP digital signature