Re: [PATCH 2/5] dt-bindings: net: Add MTIP L2 switch description (fec,mtip-switch.yaml)
From: Krzysztof Kozlowski
Date: Tue Mar 25 2025 - 11:14:33 EST
On 25/03/2025 16:05, Andrew Lunn wrote:
>> + phy-reset-gpios:
>> + deprecated: true
>> + description:
>> + Should specify the gpio for phy reset.
>
> It seem odd that a new binding has deprecated properties. Maybe add a
> comment in the commit message as to why they are there. I assume this
> is because you are re-using part of the FEC code as is, and it
> implements them?
Re-using existing driver code should not be a reason to use deprecated
properties, because you can change that common driver parts to support
both: old FEC style and new MTIP-L2-FEC switch.
Best regards,
Krzysztof