Re: [PATCH] net: atm: use sysfs_emit_at() instead of scnprintf()

[Simon Horman]

On Fri, Mar 21, 2025 at 10:45:57AM +0800, tang.dongxing@xxxxxxxxxx wrote:
> >On Mon, Mar 17, 2025 at 05:09:02PM +0800, tang.dongxing@xxxxxxxxxx wrote:
> >> >On 17/03/2025 08:51, tang.dongxing@xxxxxxxxxx wrote:> From: TangDongxing <tang.dongxing@xxxxxxxxxx>
> >> >> 
> >> >> Follow the advice in Documentation/filesystems/sysfs.rst:
> >> >> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> >> >> the value to be returned to user space.
> >> >> 
> >> >> Signed-off-by: Tang Dongxing <tang.dongxing@xxxxxxxxxx>Dear ZTE,
> >> >
> >> >Can you slow down? You sent a bunch of emails with similar issues which
> >> >means that dozen of maintainers will deal with the same issues
> >> >independently. This looks like another vivo or huawei style submission,
> >> >leading to bugs sneaked via flood of patches.
> >> >
> >> >First, fix the name used in the SoB (see submitting patches) to match
> >> >Latin transcription.
> >> >
> >> >Second, use proper SoB chain, see submitting patches.
> >> >
> >> >Third, really, really be sure that what you send is correct. You already
> >> >got quite responses, but you still keep sending patches.
> >> >
> >> >Fourth, respond to received feedback instead of flooding us with more of
> >> >this!
> >> 
> >> Dear Krzysztof,
> >> Thank you for your feedback. I apologize for my previous submissions.
> >> Regarding the issues you've pointed out:
> >> I will correct the name used in the SoB to ensure it matches the Latin transcription as required.
> >> I will double-check my work before sending any further updates.
> >> I appreciate your guidance and will follow the submission guidelines more carefully going forward. If you have any further advice or resources to help me improve my submissions, I would be grateful for your input.
> >> Best regards, 
> >> Tang Dongxing
> >
> >Thanks Tang Dongxing,
> >
> >Further to Krzystof's comments: please coordinate with your colleague
> >Xie Ludan who has also posted a patch in this area.
> >
> >  https://lore.kernel.org/all/20250317152933756kWrF1Y_e-2EKtrR_GGegq@xxxxxxxxxx/
> >
> >It will be much easier for review if there is a single patch
> >that addresses these issues for ATM.
> >
> >Also, please consider reading the following guidance on processes
> >for the networking subsystem of the Linux kernel. These are similar
> >but different to other subsystems.
> >
> >  https://docs.kernel.org/process/maintainer-netdev.html
> 
> Dear SimonHroman,
> 
> Thank you for your guidance. I have contacted Xie Ludan,
> we recommend that the community review be based on the https://lore.kernel.org/all/20250317152933756kWrF1Y_e-2EKtrR_GGegq@xxxxxxxxxx/

Thanks, understood.

> I will carefully read the the networking subsystem guidance before sending any further updates.

Likewise, thanks.