Re: [PATCH] platform: cznic: fix function parameter names

[Nathan Chancellor]

On Fri, Mar 21, 2025 at 09:53:07AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> A invalid prototype made it into a previous patch, causing an clang warning:
> 
> drivers/platform/cznic/turris-signing-key.c:25:55: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
> 
> and a slightly different warning with gcc-11 and earlier but not gcc-12 and up:
> 
> drivers/platform/cznic/turris-signing-key.c: In function 'turris_signing_key_instantiate':
> drivers/platform/cznic/turris-signing-key.c:25:43: error: parameter name omitted
> 
> Add the parameters to get a clean build with all compilers.
> 
> Fixes: 0b28b7080ef5 ("platform: cznic: Add keyctl helpers for Turris platform")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503210450.AoOpbJXC-lkp@xxxxxxxxx/
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>

You will be taking this I assume?

> ---
>  drivers/platform/cznic/turris-signing-key.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/cznic/turris-signing-key.c b/drivers/platform/cznic/turris-signing-key.c
> index 3b12e5245fb7..3827178565e2 100644
> --- a/drivers/platform/cznic/turris-signing-key.c
> +++ b/drivers/platform/cznic/turris-signing-key.c
> @@ -22,7 +22,8 @@
>  
>  #include <linux/turris-signing-key.h>
>  
> -static int turris_signing_key_instantiate(struct key *, struct key_preparsed_payload *)
> +static int turris_signing_key_instantiate(struct key *key,
> +					  struct key_preparsed_payload *payload)
>  {
>  	return 0;
>  }
> -- 
> 2.39.5
>