RE: [EXT] Re: [PATCH v4 1/2] wifi: mwifiex: Fix premature release of RF calibration data.

[Jeff Chen]

> -----Original Message-----
> From: Francesco Dolcini <francesco@xxxxxxxxxx>
> Sent: Thursday, March 20, 2025 12:29 AM
> To: Jeff Chen <jeff.chen_1@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> briannorris@xxxxxxxxxxxx; johannes@xxxxxxxxxxxxxxxx; francesco@xxxxxxxxxx;
> Pete Hsieh <tsung-hsien.hsieh@xxxxxxx>; s.hauer@xxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v4 1/2] wifi: mwifiex: Fix premature release of RF
> calibration data.
> 
> 
> Hello Jeff,
> 
> On Tue, Mar 18, 2025 at 01:07:38PM +0800, Jeff Chen wrote:
> > This patch resolves an issue where RF calibration data was being
> > released before the download process. Without this fix, the external
> > calibration data file would not be downloaded at all.
> >
> > Fixes: d39fbc88956e ("mwifiex: remove cfg_data construction")
> > Signed-off-by: Jeff Chen <jeff.chen_1@xxxxxxx>
> 
> The code looks ok to me, however I do not understand the commit you
> selected as fixes tag.
> 
> From what I understand releasing the data before using it was done since the
> initial commit 388ec385d5ce ("mwifiex: add calibration data download
> feature"). What am I missing?
> 
> Francesco

Hello Francesco,  

Thank you for reviewing the patch. You are correct-the Fixes tag I included was incorrect.
After re-examining the issue, I found that the premature release of RF calibration data 
cannot be reproduced, which invalidates the problem statement for this patch.  

I have decided to withdraw the patch. I appreciate your feedback and attention to detail, 
which helped identify this oversight.  

Best regards,  
Jeff