Re: [PATCH RFC 2/2] wcslen() prototype in string.h

[Andy Shevchenko]

On Tue, Mar 25, 2025 at 09:58:47AM -0700, Nathan Chancellor wrote:
> On Tue, Mar 25, 2025 at 06:17:34PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 25, 2025 at 08:45:19AM -0700, Nathan Chancellor wrote:

...

> > > Rename the efi function to avoid the conflict.
> > 
> > Hmm... Why not split this to two, rename patch as a standalone makes sense to
> > me even outside of this series.
> 
> How so? If nls.h is not included in printk.c via string.h, which does
> not happen without this series, what value does the rename have? I do
> not mind splitting it up that way to keep things cleaner, I am just
> wondering what would be the justification in the changelog (I guess just
> that nls.h may get included in the future for some reason)?

Inside this series the justification is obvious (a.k.a. the same), outside
yes something like "Put EFI specific function to the respective namespace
to avoid potential clash in the future when including another header."

-- 
With Best Regards,
Andy Shevchenko