Re: [PATCH v6 4/4] drm/tidss: Add OLDI bridge support

[Sverdlin, Alexander]

Thank you for your work Aradhya!

On Wed, 2025-02-26 at 23:43 +0530, Aradhya Bhatia wrote:
> From: Aradhya Bhatia <a-bhatia1@xxxxxx>
> 
> The AM62x and AM62Px SoCs feature 2 OLDI TXes each, which makes it
> possible to connect them in dual-link or cloned single-link OLDI display
> modes. The current OLDI support in tidss_dispc.c can only support for
> a single OLDI TX, connected to a VP and doesn't really support
> configuration of OLDIs in the other modes. The current OLDI support in
> tidss_dispc.c also works on the principle that the OLDI output can only
> be served by one, and only one, DSS video-port. This isn't the case in
> the AM62Px SoC, where there are 2 DSS controllers present that share the
> OLDI TXes.
> 
> Having their own devicetree and their own bridge entity will help
> support the various display modes and sharing possiblilities of the OLDI
> hardware.
> 
> For all these reasons, add support for the OLDI TXes as DRM bridges.
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> Signed-off-by: Aradhya Bhatia <a-bhatia1@xxxxxx>
> Signed-off-by: Aradhya Bhatia <aradhya.bhatia@xxxxxxxxx>

I've applied the series onto next-20250320 (+ required DT changes from
the TI tree + the parts required to wire the particular panel) and tested
with single channel AUO 800x480 LVDS panel on OLDI0. LGTM!

Tested-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>

> ---
>  drivers/gpu/drm/tidss/Makefile           |   3 +-
>  drivers/gpu/drm/tidss/tidss_dispc.c      |  24 +-
>  drivers/gpu/drm/tidss/tidss_dispc.h      |   5 +
>  drivers/gpu/drm/tidss/tidss_dispc_regs.h |  14 +
>  drivers/gpu/drm/tidss/tidss_drv.c        |   9 +
>  drivers/gpu/drm/tidss/tidss_drv.h        |   5 +
>  drivers/gpu/drm/tidss/tidss_oldi.c       | 568 +++++++++++++++++++++++
>  drivers/gpu/drm/tidss/tidss_oldi.h       |  42 ++
>  8 files changed, 668 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/gpu/drm/tidss/tidss_oldi.c
>  create mode 100644 drivers/gpu/drm/tidss/tidss_oldi.h
> 

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com