Re: [PATCH v3 3/3] leds: add new LED driver for TI LP5812

From: Markus Elfring
Date: Tue Mar 25 2025 - 15:18:19 EST



> +++ b/drivers/leds/leds-lp5812.c
> @@ -0,0 +1,2190 @@

> +static ssize_t device_enable_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{

> + mutex_lock(&chip->lock);
> + if (lp5812_read(chip, chip->regs->enable_reg, &enable)) {
> + mutex_unlock(&chip->lock);
> + return -EIO;
> + }
> + mutex_unlock(&chip->lock);
> +
> + return sprintf(buf, "%d\n", enable);
> +}


Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&chip->lock);”?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/mutex.h#L201

Regards,
Markus