Re: [PATCH v6 1/1] tracing: Show last module text symbols in the stacktrace

[Google]

On Tue, 25 Mar 2025 15:49:55 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Mon, 24 Mar 2025 23:34:52 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > 
> > Since the previous boot trace buffer can include module text address in
> > the stacktrace. As same as the kernel text address, convert the module
> > text address using the module address information.
> > 
> > 
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202503112205.joXgt8gR-lkp@xxxxxxxxx/
> > Closes: https://lore.kernel.org/oe-kbuild-all/202503112303.D7g66VSd-lkp@xxxxxxxxx/
> 
> FYI, You don't add "Reported-by" and "Closes" tags for kernel test robot
> reports for previous versions of a patch set.
> 
> It even says that in the report:
> 
>    If you fix the issue in a separate patch/commit (i.e. not just a new version of
>    the same patch/commit), kindly add following tags
>    | Reported-by: kernel test robot <lkp@xxxxxxxxx>
>    | Closes: https://lore.kernel.org/oe-kbuild-all/202503112205.joXgt8gR-lkp@xxxxxxxxx/
> 
> "not just a new version of the same patch/commit"

Ah, I got it. I missed that part.

Thanks!

> 
> 
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > ---
> >  Changes in v6:
> >   - Protect module_delta by RCU.
> >   - Make nop make_mod_delta() for CONFIG_MODULES=n.
> >   - Rebased on linux-trace/for-next.
> >  Changes in v4:
> >   - Move module_delta to trace_array again.
> >   - Use bsearch for lookup module_delta.
> >   - Revert the boolean logic to avoid '!',
> >   - Fix !CONFIG_MODULES compile errors.
> > ---
> >  kernel/trace/trace.c        |  133 +++++++++++++++++++++++++++++++++++++++++--
> >  kernel/trace/trace.h        |    8 +++
> >  kernel/trace/trace_output.c |    4 +
> >  3 files changed, 138 insertions(+), 7 deletions(-)
> > 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>