Re: [PATCH v8 3/7] i2c: Add Nuvoton NCT6694 I2C support

[Ming Yu]

Dear Andi,

Thank you for reviewing,

Andi Shyti <andi.shyti@xxxxxxxxxx> 於 2025年3月20日 週四 上午7:58寫道：
>
...
> > +enum i2c_baudrate {
> > +     I2C_BR_25K = 0,
> > +     I2C_BR_50K,
> > +     I2C_BR_100K,
> > +     I2C_BR_200K,
> > +     I2C_BR_400K,
> > +     I2C_BR_800K,
> > +     I2C_BR_1M
> > +};
>
> do we need all these frequencies? I don't see them use anywhere.
>

Originally, I used module parameters to configure these I2C's baud
rate, Do you think this approach iis suitable?

> Besides, can you please use a proper prefix? I2C_BR_* prefix
> doesn't belong to this driver.
>

Okay, I will fix these macros in the next patch.


Best regards,
Ming