Re: [PATCH 6.6 00/77] 6.6.85-rc1 review

[Dragan Simic]

Hello Harshit and Greg,

On 2025-03-26 03:33, Harshit Mogalapalli wrote:
> On 25/03/25 21:37, Dragan Simic wrote:
> > On 2025-03-25 16:07, Naresh Kamboju wrote:
> ...
> > > Build regression: arm64 dtb rockchip non-existent node or label 
> > > "vcca_0v9"
> > > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> > >
> > > ## Build log
> > > arch/arm64/boot/dts/rockchip/rk3399.dtsi:221.23-266.4: ERROR
> > > (phandle_references):
> > > /pcie@f8000000: Reference to non-existent node or label "vcca_0v9"
> > >
> > >   also defined at arch/arm64/boot/dts/rockchip/rk3399- 
> > > rockpro64.dtsi:659.8-669.3
> ...
> > This is caused by another patch from the original series failing
> > to apply due to some bulk regulator renaming.  I'll send backported
> > version of that patch soon, which should make everything fine.
>
> On ARM configs, we do see the same issue that Naresh reported.
>
> arch/arm64/boot/dts/rockchip/rk3399.dtsi:221.23-266.4: ERROR
> (phandle_references): /pcie@f8000000: Reference to non-existent node
> or label "vcca_0v9"
>  also defined at 
> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi:659.8-669.3
> ERROR: Input tree has errors, aborting (use -f to force output)
> make[3]: *** [scripts/Makefile.lib:423:
> arch/arm64/boot/dts/rockchip/rk3399-rockpro64-v2.dtb] Error 2
> make[3]: *** Waiting for unfinished jobs....
> arch/arm64/boot/dts/rockchip/rk3399.dtsi:221.23-266.4: ERROR
> (phandle_references): /pcie@f8000000: Reference to non-existent node
> or label "vcca_0v9"
>  also defined at 
> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi:659.8-669.3
> ERROR: Input tree has errors, aborting (use -f to force output)
> make[3]: *** [scripts/Makefile.lib:423:
> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtb] Error 2
> make[2]: *** [scripts/Makefile.build:480: arch/arm64/boot/dts/rockchip] 
> Error 2
> make[2]: *** Waiting for unfinished jobs....
>
> Caused by commit: 1e4bd0ec5a47 ("arm64: dts: rockchip: Add missing
> PCIe supplies to RockPro64 board dtsi") -- PATCH 42/77 of this series.
>
> We see same problem with 6.12.21-rc1 as well.
>
> Notes:
> -----
> I think Dragan was referring to upstream commit: bd1c959f37f3 ("arm64:
> dts: rockchip: Add avdd HDMI supplies to RockPro64 board dtsi") which
> will fix this problem but fails to apply due to regulator renaming in
> commit: 5c96e6330197 ("arm64: dts: rockchip: adapt regulator nodenames
> to preferred form") which is not in stable kernels(6.6.y and 6.12.y)

Exactly, the direct dependency is the commit bd1c959f37f3 ("arm64:
dts: rockchip: Add avdd HDMI supplies to RockPro64 board dtsi"),
for which I haven't sent the backported version yet.

As Diederik pointed it out already in a separate message [*] from
a couple of days ago, it might be the best to include the commit
5c96e6330197 ("arm64: dts: rockchip: adapt regulator nodenames to
preferred form") into stable kernels as well.

Obviously, including the commit 5c96e6330197 pretty much goes
against the rules of stable kernels, but it would save a lot of
time and effort in the future.

[*] https://lore.kernel.org/stable/D8ONE4WEF7A2.1OE1YY8J34MM3@xxxxxxxxx/