Re: [PATCH] x86/smpboot: Remove duplicate include of asm/spec-ctrl.h

From: xu.xin16
Date: Wed Mar 26 2025 - 02:07:46 EST


>From: Feng Wei <feng.wei8@xxxxxxxxxx>
>
>The header file <asm/spec-ctrl.h> is included twice in smpboot.c.
>This is harmless due to include guards, but redundant. Remove the duplicate
>inclusion to clean up the code.
>
>Signed-off-by: Feng Wei <feng.wei8@xxxxxxxxxx>
>Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
>---
>arch/x86/kernel/smpboot.c | 1 -
>1 file changed, 1 deletion(-)
>
>diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
>index d6cf1e23c2a3..1dd0299da294 100644
>--- a/arch/x86/kernel/smpboot.c
>+++ b/arch/x86/kernel/smpboot.c
>@@ -89,7 +89,6 @@
>#include <asm/hw_irq.h>
>#include <asm/stackprotector.h>
>#include <asm/sev.h>
>-#include <asm/spec-ctrl.h>
>
>/* representing HT siblings of each logical CPU */
>DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_sibling_map);
>--
>2.25.1
>
Tested, it's ok.

Reviewed-by: xu xin <xu.xin16@xxxxxxxxxx>