Re: [RFC PATCH v2 2/9] dt-bindings: soc: microchip: document the simple-mfd syscon on PolarFire SoC

From: Krzysztof Kozlowski
Date: Wed Mar 26 2025 - 02:55:49 EST


On 25/03/2025 17:03, Conor Dooley wrote:
> On Tue, Mar 25, 2025 at 09:13:22AM +0100, Krzysztof Kozlowski wrote:
>> On Fri, Mar 21, 2025 at 05:22:35PM +0000, Conor Dooley wrote:
>>> +title: Microchip PolarFire SoC Microprocessor Subsystem (MSS) sysreg register region
>>> +
>>> +maintainers:
>>> + - Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>> +
>>> +description:
>>> + An wide assortment of registers that control elements of the MSS on PolarFire
>>> + SoC, including pinmuxing, resets and clocks among others.
>>> +
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - const: microchip,mpfs-mss-top-sysreg
>>> + - const: syscon
>>> + - const: simple-mfd
>>
>> You need to list the children if you use simple-mfd. Commit msg
>> mentioned clock controller, so where is it?
>
> I don't think a child node is required here, there's not enough

Then this is not a simple-mfd.

Best regards,
Krzysztof