Re: [PATCH v2] staging: rtl8723bs: Rename variables v2

From: Julia Lawall
Date: Wed Mar 26 2025 - 03:07:19 EST




On Wed, 26 Mar 2025, Erick Karanja wrote:

> Rename the variable `mediaStatus` to `media_status` and variable
> `lpsVal` to `lps_val` to adhere to Linux kernel coding
> standards by using snake_case instead of CamelCase.
>
> changes in v2:
> reverted double blank line changes committed earier ensuring
> my patch contains uniform changes.

This v2 information belongsbelow the ---. It's not meaningful to people
who look at the gi log in the future, because they don't see the previous
version of the patch. The part below the --- isdiscarded when the patch
is applied.

julia

>
> Fixes checkpatch.pl warning:
> CHECK: Avoid CamelCase: <mediaStatus>
> CHECK: Avoid CamelCase: <lpsVal>
>
> Signed-off-by: Erick Karanja <karanja99erick@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/core/rtw_btcoex.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index d54095f50113..f4b19ef7b341 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -8,14 +8,14 @@
> #include <rtw_btcoex.h>
> #include <hal_btcoex.h>
>
> -void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus)
> +void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
> {
> - if ((mediaStatus == RT_MEDIA_CONNECT)
> + if ((media_status == RT_MEDIA_CONNECT)
> && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
> rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
> }
>
> - hal_btcoex_MediaStatusNotify(padapter, mediaStatus);
> + hal_btcoex_MediaStatusNotify(padapter, media_status);
> }
>
> void rtw_btcoex_HaltNotify(struct adapter *padapter)
> @@ -52,14 +52,14 @@ void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)
> void rtw_btcoex_LPS_Enter(struct adapter *padapter)
> {
> struct pwrctrl_priv *pwrpriv;
> - u8 lpsVal;
> + u8 lps_val;
>
>
> pwrpriv = adapter_to_pwrctl(padapter);
>
> pwrpriv->bpower_saving = true;
> - lpsVal = hal_btcoex_LpsVal(padapter);
> - rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lpsVal, "BTCOEX");
> + lps_val = hal_btcoex_LpsVal(padapter);
> + rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lps_val, "BTCOEX");
> }
>
> void rtw_btcoex_LPS_Leave(struct adapter *padapter)
> --
> 2.43.0
>
>
>