Re: [PATCH v2 04/10] dt-bindings: timer: Add EcoNet EN751221 "HPT" CPU Timer
From: Krzysztof Kozlowski
Date: Wed Mar 26 2025 - 04:06:52 EST
On Tue, Mar 25, 2025 at 01:43:43PM +0000, Caleb James DeLisle wrote:
> +title: EcoNet EN751221 High Precision Timer (HPT)
> +
> +maintainers:
> + - Caleb James DeLisle <cjd@xxxxxxxx>
> +
> +description:
> + The EcoNet High Precision Timer (HPT) is a timer peripheral found in various
> + EcoNet SoCs, including the EN751221 and EN751627 families. It provides per-VPE
> + count/compare registers and a per-CPU control register, with a single interrupt
> + line using a percpu-devid interrupt mechanism.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
Drop items, that's const directly.
> + - const: econet,en751221-timer
> + - items:
> + - const: econet,en751627-timer
> + - const: econet,en751221-timer
> +
> + reg: true
Widest constraints are always here.
> +
> + interrupts:
> + maxItems: 1
> + description: A percpu-devid timer interrupt shared across CPUs.
> +
> + clocks:
> + maxItems: 1
> +
> +if:
This goes under allOf:, to save re-indent later, and then after
required: block (see example-schema).
> + properties:
> + compatible:
> + contains:
> + const: econet,en751627-timer
> +then:
> + properties:
> + reg:
> + items:
> + - description: Base address for VPE timers 0 and 1
s/Base address for//
because it is redundant. Bus/parent addressing already defines this as
base address, cannot be anything else.
> + - description: Base address for VPE timers 2 and 3
> +else:
> + properties:
> + reg:
> + items:
> + - description: Base address for VPE timers 0 and 1
Best regards,
Krzysztof