Re: [PATCH 15/34] mfd: sec: use dev_err_probe() where appropriate
From: André Draszik
Date: Wed Mar 26 2025 - 05:42:59 EST
On Wed, 2025-03-26 at 08:24 +0100, Krzysztof Kozlowski wrote:
> On 23/03/2025 23:39, André Draszik wrote:
> > dev_err_probe() exists to simplify code and harmonise error messages,
> > there's no reason not to use it here.
> >
> > While at it, harmonise some error messages.
> >
> > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
> Maybe such cleanups should be before you start moving the code and
> splitting modules into i2c/core/acpm.
Sure, I can re-order them. I didn't want the new PMIC to depend on
all that cleanup, as I believe that had been previous feedback (but
maybe I misremember :-), and also to avoid the new PMIC being blocked
on potentially contentious earlier cleanup patches, if any.
> Anyway:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Thanks!
Andre'