Re: [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple Touch Bar

[Jiri Kosina]

On Tue, 25 Mar 2025, Aditya Garg wrote:

> >>> Yes I can move hid_find_field to the original location as well. But, 
> >>> I would not want to devm_kzalloc as well unnecessarily if the 
> >>> touchbar is in the basic mode instead of drm mode which will cause 
> >>> this -ENODEV to be executed right?
> >> 
> >> It shouldn't matter. hid_core calls devres_open_group() before calling
> >> .probe(), and calls devres_release_group() on failure. So yes, we'll
> >> allocate a piece of memory and release it after, but it's not something
> >> uncommon.
> > 
> > Fair. I'll send a v2
> 
> I've sent a v2 from my gmail address. Outlook is being too fussy these 
> days, so hopefully I don't have to sign off twice using gmail as well as 
> outlook.

Thanks. Please always make sure that either in the cover letter or in the 
individual patches you otline the differences between individual patch 
submissions.

-- 
Jiri Kosina
SUSE Labs