Re: [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()
From: Jani Nikula
Date: Wed Mar 26 2025 - 06:40:11 EST
On Tue, 25 Mar 2025, Lyude Paul <lyude@xxxxxxxxxx> wrote:
> A negative resolution doesn't really make any sense, no one goes into a TV
> store and says "Hello sir, I would like a negative 4K TV please", that
> would make everyone look at you funny.
That is largely the point, though. You know something fishy is going on
when you have a negative resolution. Nobody blinks an eye when you ask
for 4294963K telly, but it's still just as bonkers as that negative 4K.
I think the change at hand is fine, but please let's not pretend using
unsigned somehow protects us from negative numbers.
BR,
Jani.
--
Jani Nikula, Intel