Re: [PATCH v2 2/3] dt-bindings: PCI: xilinx-pcie: Add reset-gpios for PERST#

[Mike Looijmans]

On 25-03-2025 09:17, Krzysztof Kozlowski wrote:
> On Tue, Mar 25, 2025 at 08:18:26AM +0100, Mike Looijmans wrote:
> > Introduce optional `reset-gpios` property to enable GPIO-based control
> > of the PCIe root port PERST# signal, as described in pci.txt.
> Drop pci.txt, we don't use TXT bindings anymore.
>
> > Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx>
> > ---
> >
> > Changes in v2:
> > Add binding for reset-gpios
> So what was in v1? Empty patch?

Feedback on v1 was that I had to add bindings documentation...


> >   .../devicetree/bindings/pci/xlnx,axi-pcie-host.yaml          | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml b/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml
> > index fb87b960a250..2b0fabdd5e16 100644
> > --- a/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml
> > +++ b/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml
> > @@ -28,6 +28,9 @@ properties:
> >             ranges for the PCI memory regions (I/O space region is not
> >             supported by hardware)
> >   
> > +  reset-gpios:
> > +    maxItems: 1
> Why do you need it? It's already there, in PCI schemas, isn't it?
>
> Why is this patch needed?

Apparently not needed then, sorry for the noise.



> Best regards,
> Krzysztof

--
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@xxxxxxxx
W: www.topic.nl