Re: [PATCH v15 2/2] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface

From: Miquel Raynal
Date: Wed Mar 26 2025 - 10:55:07 EST



>> Change in [v11]
>>
>> * Changed "depends on MTD" to "select MTD" in
>> drivers/spi/Kconfig file
>
> Why? This is the only driver that selects MTD instead of depending on it.
>
>> Change in [v7]
>>
>> * Made CONFIG_SPI_QPIC_SNAND as bool
>
> Why? The driver uses MODULE_*, so a janitor may remove the latter.

Good catch, I agree on both comments.

Thanks,
Miquèl