Re: [PATCH] ACPICA: Adjust the position of code lines.

From: Rafael J. Wysocki
Date: Wed Mar 26 2025 - 11:30:21 EST


On Thu, Mar 20, 2025 at 10:33 AM Zhe Qiao <qiaozhe@xxxxxxxxxxx> wrote:
>
> In the acpica/utcache.c file, adjust the position of the
> "ACPI_MEM_TRACKING(cache->total_allocated++);" code line
> to ensure that the increment operation on total_allocated
> is included within the ACPI_DBG_TRACK_ALLOCATIONS configuration.
>
> Signed-off-by: Zhe Qiao <qiaozhe@xxxxxxxxxxx>

In order to modify ACPICA code in the Linux kernel, please first
submit the change in question to the upstream ACPICA project on GitHub
as a pull request. Once that pull request has been merged, you can
send a corresponding Linux patch with a Link: tag pointing to it, but
in principle it is not necessary to do so because ACPICA changes are
automatically integrated into the Linux code base on a more-or-less
regular basis.

Thanks!

> ---
> drivers/acpi/acpica/utcache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/utcache.c b/drivers/acpi/acpica/utcache.c
> index 85a85f7cf750..046e6ba127d4 100644
> --- a/drivers/acpi/acpica/utcache.c
> +++ b/drivers/acpi/acpica/utcache.c
> @@ -251,9 +251,9 @@ void *acpi_os_acquire_object(struct acpi_memory_list *cache)
> } else {
> /* The cache is empty, create a new object */
>
> +#ifdef ACPI_DBG_TRACK_ALLOCATIONS
> ACPI_MEM_TRACKING(cache->total_allocated++);
>
> -#ifdef ACPI_DBG_TRACK_ALLOCATIONS
> if ((cache->total_allocated - cache->total_freed) >
> cache->max_occupied) {
> cache->max_occupied =
> --
> 2.34.1
>
>