Re: [v3,net] net: phy: broadcom: Correct BCM5221 PHY model detection failure

[Florian Fainelli]

On 3/25/25 02:10, Jim Liu wrote:
> Use "BRCM_PHY_MODEL" can be applied to the entire 5221 family of PHYs.
>
> Fixes: 3abbd0699b67 ("net: phy: broadcom: add support for BCM5221 phy")
> Signed-off-by: Jim Liu <jim.t90615@xxxxxxxxx>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>
> ---
> v3:
>     modify BRCM_PHY_MODEL define

Humm, I am not super confident in modifying BRCM_PHY_MODEL() since that 
impacts the entire driver, how about just using Russell's suggestion:

if (phydev->drv->phy_id == PHY_ID_BCM5221)

all over the place? That also paves the way for getting rid of 
BRCM_PHY_MODEL() once this patch is in net-next.

Thanks!
--
Florian