Re: [PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards
From: Conor Dooley
Date: Wed Mar 26 2025 - 12:46:15 EST
On Wed, Mar 26, 2025 at 03:09:30PM +0100, Lukasz Majewski wrote:
> The measurement device on Liebherr's (LWE) boards is used to monitor
> the overall state of the device. It does have SPI interface to
> communicate with Linux host via spidev driver. Document the SPI DT
> binding as trivial SPI device.
>
> Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
> ---
You should not do a resend with no explanation as to why. Additionally,
I would like to know why my review on the original patch was ignored:
https://lore.kernel.org/all/20250225-despair-rural-dc10216005f4@spud/#t
Cheers,
Conor.
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index fadbd3c041c8..5d736a9792c2 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -161,6 +161,8 @@ properties:
> - jedec,spd5118
> # Linear Technology LTC2488
> - lineartechnology,ltc2488
> + # Liebherr on-board measurement SPI device
> + - lwe,btt
> # 5 Bit Programmable, Pulse-Width Modulator
> - maxim,ds1050
> # 10 kOhm digital potentiometer with I2C interface
> --
> 2.39.5
>
Attachment:
signature.asc
Description: PGP signature