Re: [PATCH v2] io_uring/net: use REQ_F_IMPORT_BUFFER for send_zc

[Caleb Sander Mateos]

On Wed, Mar 26, 2025 at 2:59 AM Pavel Begunkov <asml.silence@xxxxxxxxx> wrote:
>
> On 3/25/25 14:39, Caleb Sander Mateos wrote:
> > Instead of a bool field in struct io_sr_msg, use REQ_F_IMPORT_BUFFER to
> > track whether io_send_zc() has already imported the buffer. This flag
> > already serves a similar purpose for sendmsg_zc and {read,write}v_fixed.
>
> It didn't apply cleanly to for-6.15/io_uring-reg-vec, but otherwise
> looks good.

It looks like Jens dropped my earlier patch "io_uring/net: import
send_zc fixed buffer before going async":
https://lore.kernel.org/io-uring/20250321184819.3847386-3-csander@xxxxxxxxxxxxxxx/T/#u
.
Not sure why it was dropped. But this change is independent, I can
rebase it onto the current for-6.15/io_uring-reg-vec if desired.

>
> Reviewed-by: Pavel Begunkov <asml.silence@xxxxxxxxx>

Thanks!

>
> > Signed-off-by: Caleb Sander Mateos <csander@xxxxxxxxxxxxxxx>
> > Suggested-by: Pavel Begunkov <asml.silence@xxxxxxxxx>
>
> Note for the future, it's a good practice to put your sob last.

Okay. Is the preferred order of tags documented anywhere? I ran
scripts/checkpatch.pl, but it didn't have any complaints.

Best,
Caleb