Re: [PATCH] media: dt-bindings: Add OmniVision OV02C10
From: Krzysztof Kozlowski
Date: Wed Mar 26 2025 - 13:24:12 EST
On 26/03/2025 18:09, Bryan O'Donoghue wrote:
> On 26/03/2025 15:40, Krzysztof Kozlowski wrote:
>> On 26/03/2025 16:01, Bryan O'Donoghue wrote:
>>> Add bindings for OVO2C10 a two megapixel 1080p RGB sensor.
>>>
>> You already sent this and got some review. What's more, it's exactly the
>> same as OV02E10, so just put it to that file.
>>
>> Best regards,
>> Krzysztof
>
> They aren't exactly the same.
>
> The i2c address of the sensors is different 0x10 for one and 0x36 the other.
>
> Also different data-rates for each chip.
I meant bindings are exactly the same, unless I missed something.
Devices are similar enough as well.
> Seems simpler to me to have two separate files ?
Not really, more files to maintain, more trivialities to fix if we
decide to change something in all bindings (e.g. style).
Best regards,
Krzysztof