Re: [PATCH RESEND] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

[Conor Dooley]

On Wed, Mar 26, 2025 at 06:42:40PM +0100, Lukasz Majewski wrote:
> Hi Conor,
> 
> > On Wed, Mar 26, 2025 at 03:09:30PM +0100, Lukasz Majewski wrote:
> > > The measurement device on Liebherr's (LWE) boards is used to monitor
> > > the overall state of the device. It does have SPI interface to
> > > communicate with Linux host via spidev driver. Document the SPI DT
> > > binding as trivial SPI device.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
> > > ---  
> > 
> > You should not do a resend with no explanation as to why.
> > Additionally, I would like to know why my review on the original
> > patch was ignored:
> > https://lore.kernel.org/all/20250225-despair-rural-dc10216005f4@spud/#t
> > 
> 
> I've made a mistake, as I've used the lwe prefix, which is the
> different branch office for Liebherr.
> 
> As we discussed last time - it would be better to use the already
> present 'lwn' vendor prefix as several other boards from this company
> use it (display5, bk4, xea, btt3).
> 
> And this was apparent, after I've resent the patches. My mistake.
> 
> Regarding the comment - on xea, btt the binding would be used, as those
> two boards (based on imx287) are using it.
> 
> Hence, single "trivial device" would be OK.
> 
> The v2 of this patch has the proper 'lwn,btt' binding.

I'm sorry, I don't understand how this excuses using the same binding
for different devices.

> 
> > Cheers,
> > Conor.
> > 
> > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > fadbd3c041c8..5d736a9792c2 100644 ---
> > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -161,6
> > > +161,8 @@ properties:
> > >            - jedec,spd5118
> > >              # Linear Technology LTC2488
> > >            - lineartechnology,ltc2488
> > > +            # Liebherr on-board measurement SPI device
> > > +          - lwe,btt
> > >              # 5 Bit Programmable, Pulse-Width Modulator
> > >            - maxim,ds1050
> > >              # 10 kOhm digital potentiometer with I2C interface
> > > -- 
> > > 2.39.5
> > >   
> 
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@xxxxxxx

Attachment: signature.asc
Description: PGP signature