Re: [PATCH v2] sched/rt: Fix race in push_rt_task
From: Harshit Agarwal
Date: Wed Mar 26 2025 - 14:06:19 EST
> On Mar 26, 2025, at 6:18 AM, Phil Auld <pauld@xxxxxxxxxx> wrote:
>>
>
> We've got some cases that look to be hitting this as well.
>
> I'm a little concerned about turning some runtime checks into
> BUG_ON()s but in this case I think we are really just going to
> trap out on !has_pushable_tasks() check first and if not, pick
> a different task and don't drop the lock so it should pass the
> BUG_ON()s and fail to match the original task. So...
>
> Reviewed-by: Phil Auld <pauld@xxxxxxxxxx>
>
Thanks Phil for your review. Just FYI this is the link to
v3 (latest version) of this change
https://lore.kernel.org/lkml/20250225180553.167995-1-harshit@xxxxxxxxxxx/
No change here in the code w.r.t v2. I had just updated the
commit message to add stable maintainers.
Regards,
Harshit