Re: [PATCH v2 01/14] dt-bindings: regulator: Add ROHM BD96802 PMIC

[Conor Dooley]

On Wed, Mar 26, 2025 at 08:15:05AM +0200, Matti Vaittinen wrote:
> Hi Conor,
> 
> Thanks for taking a look at this :)
> 
> On 25/03/2025 19:23, Conor Dooley wrote:
> > On Mon, Mar 24, 2025 at 10:54:44AM +0200, Matti Vaittinen wrote:
> > > BD96802Qxx-C is an automotive grade configurable Power Management
> > > Integrated Circuit supporting Functional Safety features for application
> > > processors, SoCs and FPGAs. BD96802 is controlled via I2C, provides two
> > > interrupt lines and has two controllable buck regulators.
> > > 
> > > The BD96802 belongs to the family of ROHM Scalable PMICs and is intended
> > > to be used as a companion PMIC for the BD96801.
> > > 
> > > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> > > 
> > > ---
> > > Revision history:
> > >   v1 => :
> > >    - No changes
> > > ---
> > >   .../regulator/rohm,bd96802-regulator.yaml     | 44 +++++++++++++++++++
> > >   1 file changed, 44 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd96802-regulator.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/regulator/rohm,bd96802-regulator.yaml b/Documentation/devicetree/bindings/regulator/rohm,bd96802-regulator.yaml
> > > new file mode 100644
> > > index 000000000000..671eaf1096d3
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/regulator/rohm,bd96802-regulator.yaml
> > > @@ -0,0 +1,44 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/regulator/rohm,bd96802-regulator.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: ROHM BD96802 Power Management Integrated Circuit regulators
> > > +
> > > +maintainers:
> > > +  - Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > > +
> > > +description:
> > > +  This module is part of the ROHM BD96802 MFD device. For more details
> > > +  see Documentation/devicetree/bindings/mfd/rohm,bd96802-pmic.yaml.
> > > +
> > > +  The regulator controller is represented as a sub-node of the PMIC node
> > > +  on the device tree.
> > > +
> > > +  Regulator nodes should be named to buck1 and buck2.
> > 
> > Is it really needed to add a new binding for this, rather than including
> > it in the mfd binding,
> 
> A valid question. I did this because that's what I've used with all the
> other PMIC's regulator bindings. All of these have MFD counterpart:
> 
> rohm,bd71815-regulator.yaml
> rohm,bd71828-regulator.yaml
> rohm,bd71837-regulator.yaml
> rohm,bd71847-regulator.yaml
> rohm,bd9576-regulator.yaml
> rohm,bd96801-regulator.yaml
> 
> Basically, none of the MFD bindings I've written for ROHM PMICs contain the
> regulator descriptions.
> 
> The thing is that users might be used to look for the regulator bindings
> from the regulator folder. I'd like to keep this consistent, especially with
> the BD96801 because the BD96802 is intended to be used together with it.
> (BD96802 is used as a companion PMIC for the BD96801 to extend it's
> capabilities).
> 
> > particularly when this isn't actually a binding
> > for the regulator but the pattern section applies to the mfd.
> 
> Hmmm? I am not sure I understand what you mean here. I know I am really bad
> with the YAML and bindings, but if I read correctly what I've copied - the
> pattern section describes what is inside the 'regulators' node. I think this
> is similar to what we have with the rest of the ROHM PMIC bindings. Should
> they all be somehow modified?

I just think it is weird to be honest, describing the contents of
regulators node, rather than the individual regulators themselves, but
if Rob and Krzysztof, which they seem to be, I will not object.

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature