Re: [PATCH] net: dsa: felix: check felix_cpu_port_for_conduit() for failure

[Andrew Lunn]

On Wed, Mar 26, 2025 at 11:29:29PM +0500, Vitaliy Shevtsov wrote:
> On Wed, 26 Mar 2025 19:22:07 +0100, Andrew Lunn wrote:
> 
> > If i'm reading the code correctly you mean ocelot_bond_get_id()
> > returns -ENOENT?
> > 
> > If so, you should return the ENOENT, not replace it by EINVAL.
> > 
> > 	Andrew
> 
> Or maybe it's better to just return negative cpu value instead?

Yes, that is what i meant. The typical pattern is:

			int lag = ocelot_bond_get_id(ocelot, bond);
			if (lag < 0)
				return lag

	Andrew