Re: linux-6.14/arch/arm64/lib/crc-t10dif-glue.c bug report

From: Eric Biggers
Date: Wed Mar 26 2025 - 16:12:09 EST


On Wed, Mar 26, 2025 at 07:12:00PM +0000, David Binderman wrote:
> Hello there,
>
> Static analyser cppcheck says:
>
> linux-6.14/arch/arm64/lib/crc-t10dif-glue.c:53:33: error: Using pointer to local variable 'buf' that is out of scope. [invalidLifetime]
>
> Source code is
>
> return crc_t10dif_generic(crc, data, length);
>
> but this line
>
> data = buf;
>
> looks very suspicious. Suggest move local variable buf out
> to file scope.
>
> Regards
>
> David Binderman

Thanks for finding this! Kind of a silly bug, but that's what we get for
programming in C...
https://lore.kernel.org/r/20250326200812.125574-1-ebiggers@xxxxxxxxxx and
https://lore.kernel.org/r/20250326200918.125743-1-ebiggers@xxxxxxxxxx fix this
for arm and arm64.

- Eric