Re: [PATCH v2 2/2] lib/string.c: Add wcslen()
From: Nathan Chancellor
Date: Wed Mar 26 2025 - 18:36:12 EST
On Wed, Mar 26, 2025 at 08:39:37PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 26, 2025 at 7:19 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
> > #ifndef __HAVE_ARCH_STRNLEN
> > extern __kernel_size_t strnlen(const char *,__kernel_size_t);
> > #endif
> > +extern __kernel_size_t wcslen(const wchar_t *s);
>
> I'm wondering why we still continue putting this 'extern' keyword.
> Yes, I see that the rest is like this, but for new code do we really
> need it?
Yeah, I just did it to keep it consistent with what is around it but
there should be no reason that it cannot be removed. I am happy to do
that in v3 if desired.
Cheers,
Nathan