Re: [PATCH 6.1 000/197] 6.1.132-rc2 review

From: Ron Economos
Date: Wed Mar 26 2025 - 20:03:35 EST


On 3/26/25 13:10, Peter Schneider wrote:
Am 26.03.2025 um 16:44 schrieb Greg Kroah-Hartman:
This is the start of the stable review cycle for the 6.1.132 release.
There are 197 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.


Trying to build on my 2-socket Ivy Bridge Xeon E5-2697 v2 server (X86_64), I get a build error:

  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  DESCEND bpf/resolve_btfids
  INSTALL libsubcmd_headers
  CC [M]  fs/xfs/libxfs/xfs_alloc.o
In file included from ./include/linux/string.h:5,
                 from ./include/linux/uuid.h:12,
                 from ./fs/xfs/xfs_linux.h:10,
                 from ./fs/xfs/xfs.h:22,
                 from fs/xfs/libxfs/xfs_alloc.c:6:
fs/xfs/libxfs/xfs_alloc.c: In function '__xfs_free_extent_later':
fs/xfs/libxfs/xfs_alloc.c:2551:51: error: 'mp' undeclared (first use in this function); did you mean 'tp'?
 2551 |         if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len)))
      |                                                   ^~
./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
   78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
      |                                             ^
fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT'
 2551 |         if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len)))
      |             ^~~~~~~~~~~~~~
fs/xfs/libxfs/xfs_alloc.c:2551:51: note: each undeclared identifier is reported only once for each function it appears in
 2551 |         if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len)))
      |                                                   ^~
./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
   78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
      |                                             ^
fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT'
 2551 |         if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len)))
      |             ^~~~~~~~~~~~~~
./fs/xfs/xfs_linux.h:225:63: error: left-hand operand of comma expression has no effect [-Werror=unused-value]
  225 | __this_address), \
|                                                               ^
fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT'
 2551 |         if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len)))
      |             ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [scripts/Makefile.build:250: fs/xfs/libxfs/xfs_alloc.o] Error 1
make[2]: *** [scripts/Makefile.build:503: fs/xfs] Error 2
make[1]: *** [scripts/Makefile.build:503: fs] Error 2
make: *** [Makefile:2010: .] Error 2
root@linus:/usr/src/linux-stable-rc#


I have attached my .config file for review.


Beste Grüße,
Peter Schneider

Seeing this on RISC-V also.