[for-next][PATCH 2/2] tracing: Replace strncpy with memcpy for fixed-length substring copy

From: Steven Rostedt
Date: Wed Mar 26 2025 - 20:07:53 EST


From: Siddarth G <siddarthsgml@xxxxxxxxx>

checkpatch.pl reports the following warning:
WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy
(see: https://github.com/KSPP/linux/issues/90)

In synth_field_string_size(), replace strncpy() with memcpy() to copy 'len'
characters from 'start' to 'buf'. The code manually adds a NUL terminator
after the copy, making memcpy safe here.

Link: https://lore.kernel.org/20250325181232.38284-1-siddarthsgml@xxxxxxxxx
Signed-off-by: Siddarth G <siddarthsgml@xxxxxxxxx>
Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
---
kernel/trace/trace_events_synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
index 6d592cbc38e4..969f48742d72 100644
--- a/kernel/trace/trace_events_synth.c
+++ b/kernel/trace/trace_events_synth.c
@@ -207,7 +207,7 @@ static int synth_field_string_size(char *type)
if (len == 0)
return 0; /* variable-length string */

- strncpy(buf, start, len);
+ memcpy(buf, start, len);
buf[len] = '\0';

err = kstrtouint(buf, 0, &size);
--
2.47.2